Skip to content

Remove options.template to prevent rejection by certain nodemailer transport plugins - #1831

Closed
sharkinsspatial wants to merge 1 commit into
strongloop:masterfrom
sharkinsspatial:issue1828
Closed

sharkinsspatial wants to merge 1 commit into
strongloop:masterfrom
sharkinsspatial:issue1828

Conversation

@sharkinsspatial

Copy link
Copy Markdown

Removes options.template after options.html is generated to prevent
rejection by certain nodemailer transport plugins.

Removes options.template after options.html is generated to prevent
rejection by certain nodemailer transport plugins.
@slnode

slnode commented Nov 23, 2015

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@sharkinsspatial

Copy link
Copy Markdown
Author

Any update on this? Appears to ready for merge but I haven't seen any motion on it in awhile.

@bajtos

bajtos commented Jan 5, 2016

Copy link
Copy Markdown
Member

@ritch you are most familiar with this part of code, please review.

@sharkinsspatial could you please add a unit-test to verify your fix and prevent regressions in the future?

@bajtos bajtos assigned ritch and unassigned bajtos Jan 5, 2016
@superkhau

Copy link
Copy Markdown
Contributor

@ritch you are most familiar with this part of code, please review.

@sharkinsspatial could you please add a unit-test to verify your fix and prevent regressions in the future?

@ritch @sharkinsspatial Ping.

@slnode

slnode commented Mar 22, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@superkhau

Copy link
Copy Markdown
Contributor

@ritch Ping. Do you know if there are any negatives to adding this one line?

@sharkinsspatial

Copy link
Copy Markdown
Author

Can this pull request be merged by someone? Just ran into this issue again.

@slnode

slnode commented Oct 22, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

3 similar comments
@slnode

slnode commented Oct 22, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@slnode

slnode commented Oct 22, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@slnode

slnode commented Oct 22, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@superkhau

Copy link
Copy Markdown
Contributor

@bajtos What should we do here? It's been open since May.

@superkhau superkhau assigned bajtos and unassigned ritch Oct 26, 2016
@bajtos

bajtos commented Oct 26, 2016

Copy link
Copy Markdown
Member

What should we do here? It's been open since May.

We need somebody to add the unit-test or explain why adding such test is not feasible.

If @sharkinsspatial, the author of this patch, does not have the bandwidth, then it would be great if one of the functional-area owners (@loay for loopback-auth, @jannyHou / @davidcheung for connector-email) could step in and take over this work.

@bajtos bajtos changed the title Fixes issue #1828 Remove options.template to prevent rejection by certain nodemailer transport plugins Dec 1, 2016
@bajtos

bajtos commented Dec 6, 2016

Copy link
Copy Markdown
Member

Closing in favour of #3004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants